Re: [PATCH] Added test functionality for Util.h servlet

["Ilya A. Volynets-Evenbakh" <ilya@total-knowledge.com>]

And yet another thing. The comments in the header file should
not only list what is demonstrated, but also how it is demonstrated,
as well as some corner-case descriptions.


Ilya A. Volynets-Evenbakh wrote:
> Oh, another thing.
> It should be (C) by you, and 2006, not 2004.
>
> Ilya A. Volynets-Evenbakh wrote:
>   
>> 1. Bits to add new servlet seem to be missing
>>     - Top-level Makefile.adon
>>     - engine.xml
>> 2. opening form in service() method, but closing it in utilFooter()
>>     seems to be asymmetric
>> 3. Let's follow conventions of other samples, and use renderHeader &
>> renderFooter
>>     names with same signatures as other samples. One day we'll abstract them
>>     out, and make one common base servlet class that'll hold these, and
>> use it
>>     for all servlets.
>>
>> Looks good otherwise.
>>
>>   
>>     
>
>   

-- 
Ilya A. Volynets-Evenbakh
Total Knowledge. CTO
http://www.total-knowledge.com