[
Date Prev][
Date Next][
Thread Prev][
Thread Next][
Date Index][
Thread Index]
Re: cppserv patch
> Matt Klaric wrote:
> > Ilya--
> >
> > I was attempting to use cppserv on Gentoo Linux with version 2.2.8 of
> > Apache and version 1.2.11 of APR. I ran into a few problems which are
> > addressed by my attached patch.
> >
> Interesting. I currently have cppserv running happily on Gentoo
> with apache-2.2.8.
> Although I do have older version of APR installed alongside with
> apr-1.2.x.
On a different, machine that has a 0.9.x version of APR along side the
newer 1.2.x version cppserv compiles just fine. It's only on a brand
new install that only has the 1.2.x version that I have problems.
> > First, the simplest one is that Gentoo names uses the name apr-1-config
> > instead of apr-config. Thus, I added a line to check for that app after
> > checking for apr-config.
> >
> Is apr-1-config a standard name for apr-config in apr >=1.0?
> If not, then this should be a modification of the ebuild
> (you can explicitly pass full apr-config path to make)
I honestly don't know for sure what the "standard" is. This is the case
in Gentoo, but I don't know about other distros. My thought was that it
can't hurt to check for apr-1-config after checking for apr-config. At
least then, it will cope with Gentoo's potential differences--at least
until the APR ebuild can be fixed.
> > Second, a few things have apparently changed in the newer versions of
> > APR. Namely, the signature for apr_socket_create function has been
> > modified and the APR_BRIGADE_FOREACH macro has been removed.
> > Additionally, the macro APR_STATUS_IS_SUCCESS no longer exists. My
> > patch addresses each of these issues.
> >
> I still need to be able to run with apache-2.0, which your patch
> doesn't support.
>
> I guess the right thing to do is to detect which version of APR is
> in use, and do things different based on that.
A quick glance at the 0.9.x APR seemed to show that the macro changes
that I made should work in both versions. The function signature
changes might be more problematic. I didn't look into those
specifically. API changes are never fun.
> > The patch can be applied using:
> > cd cppserv-0.1.105
> > patch -p1 < bucket_brigade_upgrade.patch
> >
> >
> > Please consider it for inclusion in the next version. Let me know if
> > you have any questions. Thanks.
> >
> Thanks for the work. I'll probably cook something up based on your
> patch, and include it in 0.1.107.
Let me know if you need anything else from me in order to get this
integrated.
Also, FYI, the v0.1.106 on the sourceforge.net site appears to be
broken. Check out
http://sourceforge.net/project/showfiles.php?group_id=137205 and look at
the size of the cppserv-0.1.106.tar.bz2 file.
--Matt